Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/capacitor v4 missing imports #17

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Feature/capacitor v4 missing imports #17

merged 2 commits into from
Jan 5, 2023

Conversation

nicholemnl
Copy link
Collaborator

Issue

#14 - Cannot run latest version 0.5.0-beta.7

latest version of v4 capacitor will crash smartscanner plugin

Changes

  1. Need to implement new imports in the build.gradle, this is required after having the latest version 0.4.4 of smartscanner

@nicholemnl nicholemnl self-assigned this Jan 5, 2023
uocnb
uocnb approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@uocnb uocnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nicholemnl!

megaxayda
megaxayda approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@megaxayda megaxayda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@nicholemnl nicholemnl merged commit 51e7ab0 into feature/capacitor-v4 Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megaxayda megaxayda megaxayda approved these changes

@uocnb uocnb uocnb approved these changes

@rjmangubat23 rjmangubat23 Awaiting requested review from rjmangubat23

Assignees

@nicholemnl nicholemnl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholemnl @uocnb @megaxayda